tini: Fix compilation with musl libc 1.2.5 #23929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support POSIX basename used in musl libc 1.2.5. This fixes compilation with musl libc 1.2.5. Signed-off-by: Hauke Mehrtens <[email protected]>
|
It's been a while since I've looked at the patch system in OpenWrt. Is there a way / should we only apply this patch for musl? Otherwise, 89e1f37 looks good to me. |
Yes only this is ok |
|
I don't like this patch as it includes dynamic memory allocations, but it's probably best to do it this way to be compatible with both glibc and musl. |
|
Sorry for the late answer. I think both solutions work. The code works with Alpine patch, but it is not a compliant version of basename. The upstream project looks dead to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support POSIX basename used in musl libc 1.2.5.
This fixes compilation with musl libc 1.2.5.
Upstream PR: krallin/tini#223
Maintainer: @G-M0N3Y-2503
Compile tested: mips malta be
Run tested: None
Description: